[webkit-reviews] review denied: [Bug 44261] [GTK] Add HTTP caching support : [Attachment 65135] SoupURILoader stuff as part of webkitgtk+ core network

[bugzilla-daemon at webkit.org]

Gustavo Noronha (kov) <gns at gnome.org> has denied Sergio Villar Senin
<svillar at igalia.com>'s request for review:
Bug 44261: [GTK] Add HTTP caching support
https://bugs.webkit.org/show_bug.cgi?id=44261

Attachment 65135: SoupURILoader stuff as part of webkitgtk+ core network
https://bugs.webkit.org/attachment.cgi?id=65135&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
I have three main concerns:

1. I believe we should import the code without style changes into a
subdirectory; I know you have probably been told to change it into webkit's
style, but I think it would make backporting fixes into soup's version harder
than needed - and it's not something we plan to keep in the tree for long,
anyway
2. do we really need to import the TPL one-file library? I guess the answer is
yes (though we could use GVariant?), but then we probably need to figure out a
way of isolating it from the rest of the build as the build failure suggests
it'll be problematic =(
3. There's API mixed in there (like 
webkit_soup_http_input_stream_new/webkitSoupHttpInputStreamNew) - I think I
would prefer having this code go to WebKit/soup/; the API should be kept in
soup/GTK+-style even if we decide to move the rest (which is one more argument
in favor of keeping the style)