[webkit-reviews] review granted: [Bug 43449] [chromium] Generate drag images for HTML elements and selections. : [Attachment 65004] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Daniel Cheng <dcheng at chromium.org>'s
request for review:
Bug 43449: [chromium] Generate drag images for HTML elements and selections.
https://bugs.webkit.org/show_bug.cgi?id=43449

Attachment 65004: Patch
https://bugs.webkit.org/attachment.cgi?id=65004&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
I think the bug here is that DragImageRef shouldn't be a RetainPtr on some
platforms and a raw ptr on others.  You might use the getPtr() template, which
is how we get pointers out of raw or smart pointers when the code doesn't
necessarily know the type.

I think this is OK.  But we should file a bug about fixing DragImageRef on Mac.