[webkit-reviews] review denied: [Bug 44405] [Qt] Proper workaround for missing Gtk initialization in Adobe's flash plugins... : [Attachment 65076] Initialize Gtk if the loaded plugin is Adobe's flash player...

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Aug 22 23:02:24 PDT 2010


Andreas Kling <andreas.kling at nokia.com> has denied Dawit A. <adawit at kde.org>'s
request for review:
Bug 44405: [Qt] Proper workaround for missing Gtk initialization in Adobe's
flash plugins...
https://bugs.webkit.org/show_bug.cgi?id=44405

Attachment 65076: Initialize Gtk if the loaded plugin is Adobe's flash
player...
https://bugs.webkit.org/attachment.cgi?id=65076&action=review

------- Additional Comments from Andreas Kling <andreas.kling at nokia.com>
>WebCore/ChangeLog:5
> +	     Need a short description and bug URL (OOPS!)
ChangeLog needs to be filled out.

>WebCore/plugins/qt/PluginPackageQt.cpp:154
> +	 qDebug() << "**** PATH:" << m_path;
Please remove this, or if you really think it should stay in, clean up the
message and put it within a preprocessor conditional.

r- for those two things.

You say the wrapper needs to be fixed, how do we make sure that happens?
Is there no other workaround possible for that case?


More information about the webkit-reviews mailing list