[webkit-reviews] review requested: [Bug 44405] [Qt] Proper workaround for missing Gtk initialization in Adobe's flash plugins... : [Attachment 65076] Initialize Gtk if the loaded plugin is Adobe's flash player...

[bugzilla-daemon at webkit.org]

Dawit A. <adawit at kde.org> has asked  for review:
Bug 44405: [Qt] Proper workaround for missing Gtk initialization in Adobe's
flash plugins...
https://bugs.webkit.org/show_bug.cgi?id=44405

Attachment 65076: Initialize Gtk if the loaded plugin is Adobe's flash
player...
https://bugs.webkit.org/attachment.cgi?id=65076&action=review

------- Additional Comments from Dawit A. <adawit at kde.org>
This bug report is intended to supercede bug# 44324 and bug# 40567 as the
proper fix for the Gtk initialization problems that is prevelant in some
releases of Adobe's flash player plugins. Specifically, the patch attached
ensures that the workaround in applied ONLY to Adobe's plugin and nothing else.


I tested this change with both Adobe's proprietary plugin as well as Gnu's
gnash and everything seems to work fine. For those using the nspluginwrapper,
the Adobe workaround needs to be implemented inside of the wrapper itself since
it is responsible for loading the flash player plugin.