[webkit-reviews] review granted: [Bug 43814] selectionStart clobbered if textarea isn't focused : [Attachment 64619] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has granted Ojan Vafai <ojan at chromium.org>'s
request for review:
Bug 43814: selectionStart clobbered if textarea isn't focused
https://bugs.webkit.org/show_bug.cgi?id=43814

Attachment 64619: Patch
https://bugs.webkit.org/attachment.cgi?id=64619&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
> diff --git a/LayoutTests/fast/forms/text-control-select-blurred.html
b/LayoutTests/fast/forms/text-control-select-blurred.html

Nit: Can you add some text explaining what this is testing?


> diff --git a/WebCore/rendering/RenderTextControl.cpp
b/WebCore/rendering/RenderTextControl.cpp
>  void RenderTextControl::setSelectionStart(int start)
>  {
> -    setSelectionRange(start, max(start, selectionEnd()));
> +    HTMLTextFormControlElement* element =
static_cast<HTMLTextFormControlElement*> (node());

Nit: kill the space between > and (?  I don't see any other static_casts with
this space.