[webkit-reviews] review granted: [Bug 37859] DumpRenderTree should save a stack trace and/or dump file when it crashes : [Attachment 64618] Teach run-webkit-tests, DumpRenderTree, and WebKitTestRunner how to save crash logs on Windows

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Adam Roben (aroben)
<aroben at apple.com>'s request for review:
Bug 37859: DumpRenderTree should save a stack trace and/or dump file when it
crashes
https://bugs.webkit.org/show_bug.cgi?id=37859

Attachment 64618: Teach run-webkit-tests, DumpRenderTree, and WebKitTestRunner
how to save crash logs on Windows
https://bugs.webkit.org/attachment.cgi?id=64618&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
> diff --git a/WebKitTools/WebKitTestRunner/InjectedBundle/InjectedBundle.cpp
b/WebKitTools/WebKitTestRunner/InjectedBundle/InjectedBundle.cpp
> index
b2aa836dc4ca126c4e3287d52161fc7423c744a6..24019390b32dfca7f3a532690f3fee164e4c1
44a 100644
> --- a/WebKitTools/WebKitTestRunner/InjectedBundle/InjectedBundle.cpp
> +++ b/WebKitTools/WebKitTestRunner/InjectedBundle/InjectedBundle.cpp
> @@ -111,6 +111,7 @@ void InjectedBundle::didReceiveMessage(WKStringRef
messageName, WKTypeRef messag
>	   WKRetainPtr<WKStringRef> ackMessageBody(AdoptWK,
WKStringCreateWithCFString(CFSTR("BeginTest")));
>	   WKBundlePostMessage(m_bundle, ackMessageName.get(),
ackMessageBody.get());
>  
> +	   CRASH();

This seems like a bad idea.

Otherwise, r=me.