[webkit-reviews] review canceled: [Bug 44014] [Qt] Path: Fast approximation of stroke bounding rects : [Attachment 64609] Proposed patch v2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 17 11:20:14 PDT 2010


Ariya Hidayat <ariya.hidayat at gmail.com> has canceled Andreas Kling
<andreas.kling at nokia.com>'s request for review:
Bug 44014: [Qt] Path: Fast approximation of stroke bounding rects
https://bugs.webkit.org/show_bug.cgi?id=44014

Attachment 64609: Proposed patch v2
https://bugs.webkit.org/attachment.cgi?id=64609&action=review

------- Additional Comments from Ariya Hidayat <ariya.hidayat at gmail.com>
WebCore/html/canvas/CanvasRenderingContext2D.cpp:833
 +	    boundingRect.inflate(state().m_miterLimit + state().m_lineWidth);
This means we still ignore the CanvasStrokeStyleApplier, not sure how severe it
would be.
A workaround is to expand the boundingRect by the stroke width, sadly this does
not take into account miter join.

Clearing the review flag while this is being thought off.


More information about the webkit-reviews mailing list