[webkit-reviews] review granted: [Bug 43861] Fix issues in test results server related to times data type and test item insertion : [Attachment 64170] Proposed Patch

[bugzilla-daemon at webkit.org]

Ojan Vafai <ojan at chromium.org> has granted Victor Wang <victorw at chromium.org>'s
request for review:
Bug 43861: Fix issues in test results server related to times data type and
test item insertion
https://bugs.webkit.org/show_bug.cgi?id=43861

Attachment 64170: Proposed Patch
https://bugs.webkit.org/attachment.cgi?id=64170&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
WebKitTools/TestResultServer/model/jsonresults.py:47
 +  JSON_RESULTS_MAX_BUILDS = 750
FYI, we changed this number to 1500. See
http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/webkitpy/layout_tests/
layout_package/json_results_generator.py#L63.

WebKitTools/TestResultServer/model/jsonresults.py:282
 +	       (is_all_pass and max_time <= JSON_RESULTS_MIN_TIME)):
I think this should be a strick less-than.