[webkit-reviews] review granted: [Bug 40841] [Qt] Node that have both an opacity and a transform animation on them seem not to fire : [Attachment 59438] Rediff against trunk

[bugzilla-daemon at webkit.org]

Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Sam Magnuson
<smagnuson at netflix.com>'s request for review:
Bug 40841: [Qt] Node that have both an opacity and a transform animation on
them seem not to fire
https://bugs.webkit.org/show_bug.cgi?id=40841

Attachment 59438: Rediff against trunk
https://bugs.webkit.org/attachment.cgi?id=59438&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
WebCore/platform/graphics/qt/GraphicsLayerQt.cpp:634
 +		else if (!m_state.drawsContent && m_layer->drawsContent())
Is this an important differencial?

WebCore/platform/graphics/qt/GraphicsLayerQt.cpp:1194
 +	virtual AnimatedPropertyID getAnimatedProperty() const = 0;
We normally do not use get. Maybe just call it animatedProperty()