[webkit-reviews] review denied: [Bug 40376] [Qt] Sometimes I see pixel dust when the transform is changing rapidly with Qt graphics layers : [Attachment 59431] Rediff against trunk

[bugzilla-daemon at webkit.org]

Kenneth Rohde Christiansen <kenneth at webkit.org> has denied Sam Magnuson
<smagnuson at netflix.com>'s request for review:
Bug 40376: [Qt] Sometimes I see pixel dust when the transform is changing
rapidly with Qt graphics layers
https://bugs.webkit.org/show_bug.cgi?id=40376

Attachment 59431: Rediff against trunk
https://bugs.webkit.org/attachment.cgi?id=59431&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
Almost there, just a few nits

WebCore/platform/graphics/qt/GraphicsLayerQt.cpp:171
 +	void	handleGeometryChange()
wrong coding style... no need to add more than one space after void.

WebCore/platform/graphics/qt/GraphicsLayerQt.cpp:174
 +		// I do this here because it seems QGraphicsView doesn't seem
to take into account the translated bounding rect when prepareGeometryChange
happens
Add a dot at the end. Personally I would wrap it at the middle

WebCore/platform/graphics/qt/GraphicsLayerQt.cpp:176
 +		    const QRectF g = mapRectToScene(boundingRect());
g ? geometry?

WebCore/platform/graphics/qt/GraphicsLayerQt.cpp:453
 +	if ( transform2D != transform() ) {
Remove space after transform2D and after transform()