[webkit-reviews] review denied: [Bug 43993] Add idl and mock classes for FileSystem API's {File, Directory}Entry and related interfaces : [Attachment 64380] Patch

[bugzilla-daemon at webkit.org]

Dumitru Daniliuc <dumi at chromium.org> has denied Kinuko Yasuda
<kinuko at chromium.org>'s request for review:
Bug 43993: Add idl and mock classes for FileSystem API's {File,Directory}Entry
and related interfaces
https://bugs.webkit.org/show_bug.cgi?id=43993

Attachment 64380: Patch
https://bugs.webkit.org/attachment.cgi?id=64380&action=review

------- Additional Comments from Dumitru Daniliuc <dumi at chromium.org>
WebCore/ChangeLog:14
 +	    * WebCore.xcodeproj/project.pbxproj:
you need to add these new files to a whole lot more build files (and possibly
JSDerivedSources too): see http://trac.webkit.org/changeset/61531

WebCore/storage/DirectoryEntry.cpp:54
 +	// FIXME: to be implemented.
might be worth adding ASSERT_NOT_REACHED() to all methods that are not yet
implemented.

WebCore/storage/DirectoryEntry.idl:38
 +	    void getFile(in DOMString path, in [Optional] Flags options, in
[Optional, Callback] EntryCallback successCallback, in [Optional, Callback]
ErrorCallback errorCallback);
will "[Optional] Flags options" generate "RefPtr<Flags> options;" or just
"Flags* options"?


r- mostly because of the changes required to other build files.