[webkit-reviews] review denied: [Bug 43996] Add ability to count text matches without marking : [Attachment 64387] Patch

[bugzilla-daemon at webkit.org]

David Kilzer (ddkilzer) <ddkilzer at webkit.org> has denied Sam Weinig
<sam at webkit.org>'s request for review:
Bug 43996: Add ability to count text matches without marking
https://bugs.webkit.org/show_bug.cgi?id=43996

Attachment 64387: Patch
https://bugs.webkit.org/attachment.cgi?id=64387&action=review

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
WebCore/page/Frame.cpp:1257
 +  unsigned Frame::markAllMatchesForText(const String& target, bool caseFlag,
unsigned limit)

This method should be removed.	Since WebKit is the only caller, it should
switch to using countMatchesForText() and pass in true for markMatches.  The
WebCore.exp.in file will need to be updated to remove
WebCore::Frame::markAllMatchesForText() and to add
WebCore::Frame::countMatchesForText().


WebCore/page/Frame.h:211
 +	    unsigned markAllMatchesForText(const String&, bool caseFlag,
unsigned limit);

This declaration can be removed.


WebKit/mac/WebView/WebHTMLView.mm:6206
 +  - (NSUInteger)countMatchesForText:(NSString *)string
caseSensitive:(BOOL)caseFlag limit:(NSUInteger)limit
markMatches:(BOOL)markMatches

This method should call WebCore::Frame::countMatchesForText() instead of
WebCore::Frame::markAllMatchesForText() if it uses it.


WebKit/mac/WebView/WebPDFView.mm:633
 +  - (NSUInteger)countMatchesForText:(NSString *)string
caseSensitive:(BOOL)caseFlag limit:(NSUInteger)limit
markMatches:(BOOL)markMatches

This method should call WebCore::Frame::countMatchesForText() instead of
WebCore::Frame::markAllMatchesForText() if it uses it.


WebKit/mac/WebView/WebView.mm:4368
 +  - (NSUInteger)countMatchesForText:(NSString *)string
caseSensitive:(BOOL)caseFlag highlight:(BOOL)highlight limit:(NSUInteger)limit
markMatches:(BOOL)markMatches

This method should call WebCore::Frame::countMatchesForText() instead of
WebCore::Frame::markAllMatchesForText() if it uses it.


r- to address the above issues.