[webkit-reviews] review granted: [Bug 43512] [GTK] Use GSettings to save/restore Web Inspector settings : [Attachment 64224] use gsettings for the inspector

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has granted Gustavo Noronha (kov)
<gns at gnome.org>'s request for review:
Bug 43512: [GTK] Use GSettings to save/restore Web Inspector settings
https://bugs.webkit.org/show_bug.cgi?id=43512

Attachment 64224: use gsettings for the inspector
https://bugs.webkit.org/attachment.cgi?id=64224&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
> +#if HAVE_GSETTINGS
> +template <> GVariant* refGPtr(GVariant* ptr)
> +{
> +    if (ptr)
> +	   g_variant_ref(ptr);
> +    return ptr;
> +}
> +
> +template <> void derefGPtr(GVariant* ptr)
> +{
> +    g_variant_unref(ptr);
> +}
> +#endif
> +#if HAVE_GSETTINGS
> +template <> GVariant* refGPtr(GVariant* ptr);
> +template <> void derefGPtr(GVariant* ptr);
> +#endif

I'd rather this be unprotected by HAVE_GSETTINGS. It might be useful later
for non-GSettings code!

> +    while (*iter != NULL) {
> +	   if (g_str_equal(schemaID, *iter))
> +	       return true;
> +	   iter++;
> +    }

Style error, as the bot mentioned.

But if you change those two small nits and remove the inadvertant change to the
GIR
file, r=me. Thanks!