[webkit-reviews] review requested: [Bug 43512] [GTK] Use GSettings to save/restore Web Inspector settings : [Attachment 64224] use gsettings for the inspector

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 12 07:50:25 PDT 2010


Gustavo Noronha (kov) <gns at gnome.org> has asked  for review:
Bug 43512: [GTK] Use GSettings to save/restore Web Inspector settings
https://bugs.webkit.org/show_bug.cgi?id=43512

Attachment 64224: use gsettings for the inspector
https://bugs.webkit.org/attachment.cgi?id=64224&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
Addressed Martin's suggestion (effectiveness will be tested by the EWS, which
should have an earlier glib version ;D)

Also, I built with introspection this time, and found GSettings would cause us
trouble because it _really_ wants the schema to be installed (it aborts the
process if it is not!). I made WebKit more reliant/robust to gsettings whims in
this patch.


More information about the webkit-reviews mailing list