[webkit-reviews] review denied: [Bug 43660] GraphicsContext3D::create should take a Page, not a HostWindow : [Attachment 63792] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Aug 6 22:32:19 PDT 2010
Sam Weinig <sam at webkit.org> has denied James Robinson <jamesr at chromium.org>'s
request for review:
Bug 43660: GraphicsContext3D::create should take a Page, not a HostWindow
https://bugs.webkit.org/show_bug.cgi?id=43660
Attachment 63792: Patch
https://bugs.webkit.org/attachment.cgi?id=63792&action=review
------- Additional Comments from Sam Weinig <sam at webkit.org>
This seems like the wrong direction. Taking a Page* would be a layering
violation. Why is this necessary? Also, you are missing a ChangeLog. (Also,
why is chromium GraphicsContext3D in WebKit/chromium and not in
WebCore/platform?) r-.
More information about the webkit-reviews
mailing list