[webkit-reviews] review denied: [Bug 38629] [WTFURL] Add a file URL parser : [Attachment 55210] Patch

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has denied Adam Barth <abarth at webkit.org>'s request
for review:
Bug 38629: [WTFURL] Add a file URL parser
https://bugs.webkit.org/show_bug.cgi?id=38629

Attachment 55210: Patch
https://bugs.webkit.org/attachment.cgi?id=55210&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
> +// Copyright 2007, Google Inc. All rights reserved.
> +//
> +// Redistribution and use in source and binary forms, with or without
> +// modification, are permitted provided that the following conditions are
> +// met:
> +//
> +//	  * Redistributions of source code must retain the above copyright
> +// notice, this list of conditions and the following disclaimer.
> +//	  * Redistributions in binary form must reproduce the above
> +// copyright notice, this list of conditions and the following disclaimer
> +// in the documentation and/or other materials provided with the
> +// distribution.
> +//	  * Neither the name of Google Inc. nor the names of its
> +// contributors may be used to endorse or promote products derived from
> +// this software without specific prior written permission.
> +//
> +// THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
> +// "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
> +// LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
> +// A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
> +// OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
> +// SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
> +// LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
> +// DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
> +// THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
> +// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
> +// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

We traditionally use c-style comments for these blocks.

> +
> +template<typename CHAR>

We usually use TitleCase for types, not all caps.

> +    static inline bool isWindowsDriveLetter(CHAR ch)
> +    {
> +	   return (ch >= 'A' && ch <= 'Z') || (ch >= 'a' && ch <= 'z');

Can this use isASCIIAlpha()?