[webkit-reviews] review denied: [Bug 43400] Add priority attribute to XMLHttpRequest : [Attachment 63617] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied James Simonsen
<simonjam+webkit at google.com>'s request for review:
Bug 43400: Add priority attribute to XMLHttpRequest
https://bugs.webkit.org/show_bug.cgi?id=43400

Attachment 63617: Patch
https://bugs.webkit.org/attachment.cgi?id=63617&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
WebCore/xml/XMLHttpRequest.cpp:401
 +	const char* const names[5] = { "critical", "high", "normal", "low",
"lowest" };
Since we have this list...

WebCore/xml/XMLHttpRequest.cpp:412
 +	if (s == "critical") {
why not just use it here.  And use a for loop for the search?  Sure, it's
"slow", but this code is not hot.  And will be less code (and less error
prone).

Otherwise this looks OK.