[webkit-reviews] review denied: [Bug 41215] JIT property access should mark internal references to GC'd objects : [Attachment 63662] patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has denied Nathan Lawrence
<nlawrence at apple.com>'s request for review:
Bug 41215: JIT property access should mark internal references to GC'd objects
https://bugs.webkit.org/show_bug.cgi?id=41215

Attachment 63662: patch
https://bugs.webkit.org/attachment.cgi?id=63662&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
I think this is the kind of patch that would benefit from some line-by-line
explanation in the ChangeLog.

+	 compileGetDirectOffset(protoObject, regT1, regT1, regT2,
cachedOffset);
+	 move(regT2, regT0);

I think it's layering violation to require the JIT to know which temporary
registers to use, because some temporaries on some platforms change the size of
the instruction. That's very subtle, and likely to go wrong in the future. I'd
prefer having compileGetDirectOffset use a MacroAssembler API that guarantees a
constant size for its instructions.