[webkit-reviews] review granted: [Bug 43402] Web Inspector: Cleanup InspectorBackend before future changes for Remote Debugging protocol.. : [Attachment 63300] [patch] initial version.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 2 23:23:34 PDT 2010


Yury Semikhatsky <yurys at chromium.org> has granted Ilya Tikhonovsky
<loislo at chromium.org>'s request for review:
Bug 43402: Web Inspector: Cleanup InspectorBackend before future changes for
Remote Debugging protocol..
https://bugs.webkit.org/show_bug.cgi?id=43402

Attachment 63300: [patch] initial version.
https://bugs.webkit.org/attachment.cgi?id=63300&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
WebCore/inspector/CodeGeneratorInspector.pm:260
 +	# "
remove this?

WebCore/inspector/Inspector.idl: 
 +	    void saveSessionSettings(in String settings);
maybe call it handler not agent?


More information about the webkit-reviews mailing list