[webkit-reviews] review granted: [Bug 43221] Move WebGL-specific code out of GraphicsContext3D so that G3D can be used as a generic accelerated drawing API : [Attachment 63297] Patch

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted James Robinson
<jamesr at chromium.org>'s request for review:
Bug 43221: Move WebGL-specific code out of GraphicsContext3D so that G3D can be
used as a generic accelerated drawing API
https://bugs.webkit.org/show_bug.cgi?id=43221

Attachment 63297: Patch
https://bugs.webkit.org/attachment.cgi?id=63297&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
WebCore/html/canvas/WebGLRenderingContext.cpp:223
 +	m_context->attachShader(program ? program->object() : 0, shader ?
shader->object() : 0);
This null checking of program seems unnecessary given the null
test done by validateWebGLObject.  hmm... should validateWebGLObject
be modified to also null check program->object()?  same goes for
the rest of the null checking in this file.

WebCore/html/canvas/WebGLRenderingContext.cpp:330
 +		    static const int kTextureWrapR = 0x8072;
nit: kTextureWrapR -> textureWrapR


otherwise, R=me

this is very nice cleanup of GC3D.  it was always bothersome that
code in platform/graphics depended back on code in html/canvas.