[webkit-reviews] review granted: [Bug 38344] Remove custom bindings for HTMLInputElement : [Attachment 54732] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 38344: Remove custom bindings for HTMLInputElement
https://bugs.webkit.org/show_bug.cgi?id=38344

Attachment 54732: Patch
https://bugs.webkit.org/attachment.cgi?id=54732&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
I think HTMLInputElement.h needs a comment as to why we're adding these.  But I
think this looks OK.

Should we be be making selectionStart, etc. virtual and overriding them in
HTMLIntputElement as private members?  Should we change the baseclass to take
an ExceptionCode and only throw it for HTMLInputElement?

I think this is OK as is, but I worry that folks could easily use the wrong
one.