[webkit-reviews] review denied: [Bug 38368] When FastMalloc Returns memory often left with lots of small spans : [Attachment 54776] second patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied Stephanie Lewis <slewis at apple.com>'s
request for review:
Bug 38368: When FastMalloc Returns memory often left with lots of small spans
https://bugs.webkit.org/show_bug.cgi?id=38368

Attachment 54776: second patch
https://bugs.webkit.org/attachment.cgi?id=54776&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
The EWS thinks this will break leopard:
fzzgiiisjukfwleasczjmdxaevcz/JavaScriptCorePrefix.h -c
/Users/eseidel/Projects/MacEWS/JavaScriptCore/wtf/FastMalloc.cpp -o
/Users/eseidel/Projects/MacEWS/WebKitBuild/JavaScriptCore.build/Release/JavaScr
iptCore.build/Objects-normal/i386/FastMalloc.o
cc1plus: warnings being treated as errors
/Users/eseidel/Projects/MacEWS/JavaScriptCore/wtf/FastMalloc.cpp:1281: warning:
implicit conversion shortens 64-bit value into a 32-bit value
/Users/eseidel/Projects/MacEWS/JavaScriptCore/wtf/FastMalloc.cpp: In member
function ‘void WTF::TCMalloc_PageHeap::scavenge()’:
/Users/eseidel/Projects/MacEWS/JavaScriptCore/wtf/FastMalloc.cpp:1546: warning:
implicit conversion shortens 64-bit value into a 32-bit value
distcc[85602] ERROR: compile
/Users/eseidel/Projects/MacEWS/JavaScriptCore/wtf/FastMalloc.cpp on localhost
failed