[webkit-reviews] review denied: [Bug 38297] Webkit doesn't compile with 3D-canvas enabled and video disabled : [Attachment 54662] paragraph style fix

[bugzilla-daemon at webkit.org]

David Levin <levin at chromium.org> has denied Noam Rosenthal
<noam.rosenthal at nokia.com>'s request for review:
Bug 38297: Webkit doesn't compile with 3D-canvas enabled and video disabled
https://bugs.webkit.org/show_bug.cgi?id=38297

Attachment 54662: paragraph style fix
https://bugs.webkit.org/attachment.cgi?id=54662&action=review

------- Additional Comments from David Levin <levin at chromium.org>

> diff --git a/WebCore/bindings/js/JSWebGLRenderingContextCustom.cpp
b/WebCore/bindings/js/JSWebGLRenderingContextCustom.cpp
> index e336027..9481a0c 100644
> --- a/WebCore/bindings/js/JSWebGLRenderingContextCustom.cpp
> +++ b/WebCore/bindings/js/JSWebGLRenderingContextCustom.cpp
> @@ -32,10 +32,18 @@
>  #include "ExceptionCode.h"
>  #include "HTMLCanvasElement.h"
>  #include "HTMLImageElement.h"
> +
> +#if ENABLE(VIDEO)
>  #include "HTMLVideoElement.h"
> +#endif
> +
>  #include "JSHTMLCanvasElement.h"
>  #include "JSHTMLImageElement.h"
> +
> +#if ENABLE(VIDEO)
>  #include "JSHTMLVideoElement.h"
> +#endif
> +
>  #include "JSImageData.h"
>  #include "JSWebGLBuffer.h"
>  #include "JSWebGLFloatArray.h"

This has the same problem that Darin noted last time.  It should look some
thing like this (note that the ifdef'ed includes are placed after all others):

#include "ExceptionCode.h"
#include "HTMLCanvasElement.h"
#include "HTMLImageElement.h"
#include "JSHTMLCanvasElement.h"
#include "JSHTMLImageElement.h"
#include "JSImageData.h"
#include "JSWebGLBuffer.h"
#include "JSWebGLFloatArray.h"

#if ENABLE(VIDEO)
#include "HTMLVideoElement.h"
#include "JSHTMLVideoElement.h"
#endif