[webkit-reviews] review granted: [Bug 37023] [Qt] Expose HTMLTokenizer yielding parameters : [Attachment 54667] 2nd try, using DynamicProperties

[bugzilla-daemon at webkit.org]

Simon Hausmann <hausmann at webkit.org> has granted Laszlo Gombos
<laszlo.1.gombos at nokia.com>'s request for review:
Bug 37023: [Qt] Expose HTMLTokenizer yielding parameters
https://bugs.webkit.org/show_bug.cgi?id=37023

Attachment 54667: 2nd try, using DynamicProperties
https://bugs.webkit.org/attachment.cgi?id=54667&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
> Index: WebKit/qt/ChangeLog
> ===================================================================
> --- WebKit/qt/ChangeLog	(revision 58467)
> +++ WebKit/qt/ChangeLog	(working copy)
> @@ -1,3 +1,16 @@
> +2010-04-28  Laszlo Gombos  <laszlo.1.gombos at nokia.com>
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   [Qt] Expose HTMLTokenizer yielding parameters
> +	   https://bugs.webkit.org/show_bug.cgi?id=37023
> +
> +	   Enables to set TimeDelay and ChunkSize for 
> +	   HTMLTokenizer.
> +
> +	   * Api/qwebpage.cpp:
> +	   (QWebPagePrivate::dynamicPropertyChangeEvent):
> +
>  2010-04-28  Laszlo Gombos  <laszlo.1.gombos at nokia.com>
>  
>	   Unreviewed, Qt build fix.
> Index: WebKit/qt/Api/qwebpage.cpp
> ===================================================================
> --- WebKit/qt/Api/qwebpage.cpp	(revision 58462)
> +++ WebKit/qt/Api/qwebpage.cpp	(working copy)
> @@ -1219,6 +1219,14 @@ void QWebPagePrivate::dynamicPropertyCha
>	       view->forceLayout();
>	   }
>      }
> +    else if (event->propertyName() == "HTMLTokenizerChunkSize") {
> +	   int chunkSize = q->property("HTMLTokenizerChunkSize").toInt();
> +	   q->handle()->page->setCustomHTMLTokenizerChunkSize(chunkSize);
> +    }
> +    else if (event->propertyName() == "HTMLTokenizerTimeDelay") {
> +	   double timeDelay = q->property("HTMLTokenizerTimeDelay").toDouble();

> +	   q->handle()->page->setCustomHTMLTokenizerTimeDelay(timeDelay);
> +    }
>  }
>  
>  void QWebPagePrivate::shortcutOverrideEvent(QKeyEvent* event)
WebKit/qt/Api/qwebpage.cpp:1222
 +	else if (event->propertyName() == "HTMLTokenizerChunkSize") {
Shouldn't the else be merged with the previous line? :)

WebKit/qt/Api/qwebpage.cpp:1230
 +  }
It would be nice to call the base implementation here, just for future
proofing.