[webkit-reviews] review denied: [Bug 38292] [Chromium] Add frame origins to ResourceRequest : [Attachment 54636] patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Apr 28 16:17:40 PDT 2010
Adam Barth <abarth at webkit.org> has denied Nate Chapin <japhet at chromium.org>'s
request for review:
Bug 38292: [Chromium] Add frame origins to ResourceRequest
https://bugs.webkit.org/show_bug.cgi?id=38292
Attachment 54636: patch
https://bugs.webkit.org/attachment.cgi?id=54636&action=review
------- Additional Comments from Adam Barth <abarth at webkit.org>
WebKit/chromium/public/WebURLRequest.h:149
+ WEBKIT_API WebURL frameOrigin() const;
I think we should be decoupling URL requests from frames, not make them more
tightly coupled. Why should a URL request know that a frame exists?
This patch tells me none of the *why* behind this change.
More information about the webkit-reviews
mailing list