[webkit-reviews] review granted: [Bug 38286] Need to call FrameView::scrollPositionChanged when changing the scroll position when the ScrollView does not have a platformWidget : [Attachment 54628] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 28 16:11:13 PDT 2010


Darin Adler <darin at apple.com> has granted James Robinson
<jamesr at chromium.org>'s request for review:
Bug 38286: Need to call FrameView::scrollPositionChanged when changing the
scroll position when the ScrollView does not have a platformWidget
https://bugs.webkit.org/show_bug.cgi?id=38286

Attachment 54628: Patch
https://bugs.webkit.org/attachment.cgi?id=54628&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
r=me

> +    virtual void scrollPositionChanged() {}

I'd prefer that this be private. There's no need for code outside the class to
ever call this and a derived class can override a function even if it's
private.


More information about the webkit-reviews mailing list