[webkit-reviews] review denied: [Bug 38149] check-webkit-style should not run the carriage checker on Windows-only files : [Attachment 54351] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 27 00:17:00 PDT 2010


Shinichiro Hamaji <hamaji at chromium.org> has denied Dumitru Daniliuc
<dumi at chromium.org>'s request for review:
Bug 38149: check-webkit-style should not run the carriage checker on
Windows-only files
https://bugs.webkit.org/show_bug.cgi?id=38149

Attachment 54351: patch
https://bugs.webkit.org/attachment.cgi?id=54351&action=review

------- Additional Comments from Shinichiro Hamaji <hamaji at chromium.org>
Thanks for addressing this issue.

Putting r- as I agree with Chris. Maybe we should just put .vcproj file into
the skipped list.

> Index: LayoutTests/storage/quota-tracking.html
> ===================================================================
> --- LayoutTests/storage/quota-tracking.html	(revision 58269)
> +++ LayoutTests/storage/quota-tracking.html	(working copy)

This change isn't related to this bug.


More information about the webkit-reviews mailing list