[webkit-reviews] review granted: [Bug 38177] Add specialized thunks for a char code related string functions : [Attachment 54389] Patch

[bugzilla-daemon at webkit.org]

Maciej Stachowiak <mjs at apple.com> has granted Oliver Hunt <oliver at apple.com>'s
request for review:
Bug 38177: Add specialized thunks for a char code related string functions
https://bugs.webkit.org/show_bug.cgi?id=38177

Attachment 54389: Patch
https://bugs.webkit.org/attachment.cgi?id=54389&action=review

------- Additional Comments from Maciej Stachowiak <mjs at apple.com>
JavaScriptCore/ChangeLog:17
 +	    (JSC::SpecializedThunkJIT::tagReturnAsJSCell):
I know this comment is a bit late, but I think the term "thunk" for these
doesn't match standard usage. Doesn't match any of the definitions here:
http://en.wikipedia.org/wiki/Thunk
I can't think of an accurate but brief term offhand. Maybe "Stub", though we
also have JIT stubs.

Patch otherwise looks correct. Please double-check that there is really a perf
gain, if so, r=me.