[webkit-reviews] review requested: [Bug 30457] Allow image requests started from unload handlers to outlive the page : [Attachment 54346] Attempt #6 (or thereabouts)

[bugzilla-daemon at webkit.org]

Nate Chapin <japhet at chromium.org> has asked  for review:
Bug 30457: Allow image requests started from unload handlers to outlive the
page
https://bugs.webkit.org/show_bug.cgi?id=30457

Attachment 54346: Attempt #6 (or thereabouts)
https://bugs.webkit.org/attachment.cgi?id=54346&action=review

------- Additional Comments from Nate Chapin <japhet at chromium.org>
Sorry for the months-long delay.

The main differences between this and the previous version are the creation of
dummy objects, rather than keeping the old objects alive.  When a new Request
is constructed to outlive its page, it holds a RefPtr to the relevant Frame,
but it creates a dummy Document and DocLoader to use for the load.  If we try
to null the main document loader of a FrameLoader that has a pending outliving
page request, we replace the current document loader with a dummy instead of a
null.

The layout tests should be identical to the previous version. I've tested every
example I knew of that triggered the crash in the original commit and it
appears to be resolved.