[webkit-reviews] review denied: [Bug 38135] Include RuntimeEnabledFeatures in the Qt build : [Attachment 54325] Initial patch

[bugzilla-daemon at webkit.org]

David Levin <levin at chromium.org> has denied Garret Kelly (Google)
<gdk at chromium.org>'s request for review:
Bug 38135: Include RuntimeEnabledFeatures in the Qt build
https://bugs.webkit.org/show_bug.cgi?id=38135

Attachment 54325: Initial patch
https://bugs.webkit.org/attachment.cgi?id=54325&action=review

------- Additional Comments from David Levin <levin at chromium.org>
WebCore/websockets/WebSocket.cpp:81
 +  static bool webSocketsAvailable = true;
There is no explanation for this change in the ChangeLog.


WebCore/ChangeLog:5
 +	    Include RuntimeEnabledFeatures in the Qt build.
It sounds like folks who work on Qt aren't convinced that this is a change they
want.


Why not just have a implementation of RuntimeEnabledFeatures that just returns
true and use that for Qt (and include it with the other patch that needs it)?