[webkit-reviews] review denied: [Bug 38116] Media queries empty values : [Attachment 54281] patch 1

[bugzilla-daemon at webkit.org]

Kenneth Rohde Christiansen <kenneth at webkit.org> has denied Luiz Agostini
<luiz.agostini at openbossa.org>'s request for review:
Bug 38116: Media queries empty values
https://bugs.webkit.org/show_bug.cgi?id=38116

Attachment 54281: patch 1
https://bugs.webkit.org/attachment.cgi?id=54281&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>

WebCore/ChangeLog:19
 +	    corrected here. After landing this patch it will. The following
corrects the view
I dont think you should add things like "after landing this patch" in the
ChangeLog

WebCore/css/CSSValueKeywords.in:718
 +  windowed
This belongs to another patch. It is not related.

WebCore/css/MediaQueryExp.h:55
 +	bool valueParseError() const { return m_valueParseError; }
I do not like the name of the method. What about valueIsValid() or so?