[webkit-reviews] review granted: [Bug 30623] [GTK] Enable DOM clipboard and drag-and-drop access : [Attachment 54159] Make the DataObject have 'live' access to the clipboard

[bugzilla-daemon at webkit.org]

Gustavo Noronha (kov) <gns at gnome.org> has granted Martin Robinson
<mrobinson at webkit.org>'s request for review:
Bug 30623: [GTK] Enable DOM clipboard and drag-and-drop access
https://bugs.webkit.org/show_bug.cgi?id=30623

Attachment 54159: Make the DataObject have 'live' access to the clipboard
https://bugs.webkit.org/attachment.cgi?id=54159&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
 8	   Make ClipboardGtk a "live" DataTransfer object, able to modify
 9	   modify the clipboard when setData(...) is called.

one modify too many =)

WebCore/platform/gtk/ClipboardGtk.cpp:50
 +  }
I think you should avoid breaking lines before you have the first argument in,
in WebKit. It's fairly common having longer lines, so it's not an issue.

WebCore/platform/gtk/DataObjectGtk.cpp:52
 +	replaceNonBreakingSpaceWithSpace(m_text);

I believe this is a good idea, but is this behaviour specified somewhere? I
have been biten at least once by non-breaking-spaces after copying/pasting from
ephy =/

WebCore/platform/gtk/PasteboardHelper.cpp:101
 +	}

I am looking at these whiles and thinking they would look better as fors, given
they're structured exactly as fors, but your take.

WebCore/platform/gtk/PasteboardGtk.cpp:64
 +				   strlen(clipboardData->markup()));

This seems to be an independant bug fix, that should go in a separate commit.
Please do that (r=me on it).

Hrm... I think the contextual review thing should probably add more lines for
context. One line is not very useful =). Thanks for the patch, it looks right
to me.