[webkit-reviews] review requested: [Bug 37276] LayoutTests/fast/canvas/pointInPath.html passed, actually it failed : [Attachment 54187] patch2

[bugzilla-daemon at webkit.org]

qi <qi.2.zhang at nokia.com> has asked  for review:
Bug 37276: LayoutTests/fast/canvas/pointInPath.html passed, actually it failed
https://bugs.webkit.org/show_bug.cgi?id=37276

Attachment 54187: patch2
https://bugs.webkit.org/attachment.cgi?id=54187&action=review

------- Additional Comments from qi <qi.2.zhang at nokia.com>
Based on Laszlo and Chang's comments, I did some change:
1> Take the code for checking point on the border to a function
2> Used a simplified formula, but I did a little bit change. Because we do need
to check if the point.y is between p1.y and p2.y. For example: if
p1.x==p2.x==p.x, but p1.y!=p2.y, any p.y will still make
(y2-y1)*(x-x1)==(y-y1)*(x2-x1) true.
3> We don't need to care point n-1 to 0, because path will force n-1 is same
with 0 to close the path.
4> Remove pointInPath-expected.txt from qt as Laszlo said.
5> Put some comments about algorithm.