[webkit-reviews] review denied: [Bug 25882] User paths exposed on file drop : [Attachment 54175] Patch with layout tests

[bugzilla-daemon at webkit.org]

Jian Li <jianli at chromium.org> has denied Daniel Cheng <dcheng at chromium.org>'s
request for review:
Bug 25882: User paths exposed on file drop
https://bugs.webkit.org/show_bug.cgi?id=25882

Attachment 54175: Patch with layout tests
https://bugs.webkit.org/attachment.cgi?id=54175&action=review

------- Additional Comments from Jian Li <jianli at chromium.org>
WebCore/platform/mac/ClipboardMac.h:89
 +	bool m_filenamesSetBySelf;
Might be better to name it as m_isFilenamesSetBySelf.

WebCore/platform/mac/ClipboardMac.mm:108
 +  static void addHTMLClipboardTypesForCocoaType(HashSet<String>& resultTypes,
const NSString *cocoaType, bool filenamesSetBySelf, NSPasteboard *pasteboard)
Since now we add only one type to resultTypes, how about changing the function
to return a type string, instead of passing resultTypes? The caller could then
add the type to the set.

WebCore/platform/mac/ClipboardMac.mm:152
 +	if (cocoaType == NSFilenamesPboardType)
You should say:
   if ( [cocoaType isEqualToString:NSFilenamesPboardType])