[webkit-reviews] review granted: [Bug 37820] Web Inspector: Aggregated time stats should be visible in Timeline record Popup : [Attachment 54160] [patch] Second iteration.

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has granted Ilya Tikhonovsky
<loislo at chromium.org>'s request for review:
Bug 37820: Web Inspector: Aggregated time stats should be visible in Timeline
record Popup
https://bugs.webkit.org/show_bug.cgi?id=37820

Attachment 54160: [patch] Second iteration.
https://bugs.webkit.org/attachment.cgi?id=54160&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
r+ with comments. please address them prior to landing.

WebCore/inspector/InspectorTimelineAgent.cpp:59
 +	if (m_gcEvents.size()) {
Replace with guard expression?

WebCore/inspector/front-end/TimelinePanel.js:1005
 +	_calculateAggregatedStats: function(categories)
It would be great to remove the 0.00001 hack and to do as much of this as
possible lazily (i.e. only calculate self time on record add).