[webkit-reviews] review granted: [Bug 37946] Web Inspector: REGRESSION(56051) Docking the inspector is broken on Windows : [Attachment 54163] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 23 08:27:48 PDT 2010


Pavel Feldman <pfeldman at chromium.org> has granted Yury Semikhatsky
<yurys at chromium.org>'s request for review:
Bug 37946: Web Inspector: REGRESSION(56051) Docking the inspector is broken on
Windows
https://bugs.webkit.org/show_bug.cgi?id=37946

Attachment 54163: patch
https://bugs.webkit.org/attachment.cgi?id=54163&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
WebKit/win/WebCoreSupport/WebInspectorClient.cpp:364
 +	    if (shouldAttach && !canAttachWindow())
This check could be done early.


More information about the webkit-reviews mailing list