[webkit-reviews] Turning off “review canceled” mail

[Darin Adler]

On Apr 22, 2010, at 3:09 PM, Dan Bernstein wrote:

> Does anyone find the “review canceled” messages useful? Is it technically possible to turn them off?

I sometimes do, when looking at mail by thread to know not to bother looking at a patch.

But I find these useless and annoying in these cases:

    1) Where an old patch is being canceled just to be replaced by a new patch.
    2) When the commit queue is doing it just to prevent it from looking like it's a not-yet-committed patch.
    3) When human beings do it just to prevent a patch from looking like a not-yet-committed patch.

Originally I thought we could use the RESOLVED state of a bug to indicate a patch was committed but that doesn’t work because people use queries that don’t take the state into account and because people use the same bug for more than one patch.

Maybe we need a separate flag to indicate that a patch is committed so we don’t have to reset it’s reviewed state to indicate it’s landed. I think it would be nice to be able to clearly see who reviewed a patch.

But I guess I wouldn’t be heartbroken if we just did what you suggest, Dan.

    -- Darin