[webkit-reviews] Turning off “review canceled” mail

Dan Bernstein mitz at apple.com
Thu Apr 22 17:42:24 PDT 2010


On Apr 22, 2010, at 5:29 PM, Darin Adler wrote:

> On Apr 22, 2010, at 3:09 PM, Dan Bernstein wrote:
> 
>> Does anyone find the “review canceled” messages useful? Is it technically possible to turn them off?
> 
> I sometimes do, when looking at mail by thread to know not to bother looking at a patch.
> 
> But I find these useless and annoying in these cases:
> 
>    1) Where an old patch is being canceled just to be replaced by a new patch.
>    2) When the commit queue is doing it just to prevent it from looking like it's a not-yet-committed patch.

This is my main problem. Almost every webkit-changes messages now comes with a corresponding webkit-reviews messages, and they are not even threaded.

> Maybe we need a separate flag to indicate that a patch is committed so we don’t have to reset it’s reviewed state to indicate it’s landed. I think it would be nice to be able to clearly see who reviewed a patch.

Yes, not resetting the review flag wholesale would be a much better solution.

> But I guess I wouldn’t be heartbroken if we just did what you suggest, Dan.

Or I could set up a mail filter, but that would only benefit me.

Thanks,
—Dan


More information about the webkit-reviews mailing list