[webkit-reviews] review denied: [Bug 32509] [Qt] 3rd edition phones lack character echo in web input fields : [Attachment 53671] patch

[bugzilla-daemon at webkit.org]

Simon Hausmann <hausmann at webkit.org> has denied Samuel Nevala
<samuel.nevala at digia.com>'s request for review:
Bug 32509: [Qt] 3rd edition phones lack character echo in web input fields
https://bugs.webkit.org/show_bug.cgi?id=32509

Attachment 53671: patch
https://bugs.webkit.org/attachment.cgi?id=53671&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
I can do an initial review on the generics, but for exact workings of the
editing code
I'm not the right one to do the review.

> diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
> index c27fce0..c3c01e1 100644
> --- a/WebCore/ChangeLog
> +++ b/WebCore/ChangeLog
> @@ -1,3 +1,25 @@
> +2010-04-19  Samuel Nevala  <samuel.nevala at digia.com>
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   [Qt] 3rd edition phones lack character echo in web input fields
> +
> +	   https://bugs.webkit.org/show_bug.cgi?id=32509
> +

Please explain your change in the changelog.

> --- a/WebCore/WebCore.pro
> +++ b/WebCore/WebCore.pro
> @@ -568,6 +568,7 @@ SOURCES += \
>      editing/RemoveNodePreservingChildrenCommand.cpp \
>      editing/ReplaceNodeWithSpanCommand.cpp \
>      editing/ReplaceSelectionCommand.cpp \
> +    editing/ReplaceTextInNodeCommand.cpp \
>      editing/SelectionController.cpp \
>      editing/SetNodeAttributeCommand.cpp \
>      editing/SmartReplace.cpp \
> @@ -1289,6 +1290,7 @@ HEADERS += \
>      editing/RemoveNodePreservingChildrenCommand.h \
>      editing/ReplaceNodeWithSpanCommand.h \
>      editing/ReplaceSelectionCommand.h \
> +    editing/ReplaceTextInNodeCommand.h \
>      editing/SelectionController.h \
>      editing/SetNodeAttributeCommand.h \
>      editing/SmartReplace.h \

When adding new files to the build I think you'll have to add them to the
other build systems, too.

> +UChar CharacterData::secureTextChar()

Shouldn't this function be const?