[webkit-reviews] review denied: [Bug 37782] new-run-webkit-tests: add a "dryrun" port that can be used to trace expectations on other platforms : [Attachment 53736] more feedback from eseidel
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Apr 19 16:36:23 PDT 2010
Adam Barth <abarth at webkit.org> has denied Dirk Pranke <dpranke at chromium.org>'s
request for review:
Bug 37782: new-run-webkit-tests: add a "dryrun" port that can be used to trace
expectations on other platforms
https://bugs.webkit.org/show_bug.cgi?id=37782
Attachment 53736: more feedback from eseidel
https://bugs.webkit.org/attachment.cgi?id=53736&action=review
------- Additional Comments from Adam Barth <abarth at webkit.org>
+ def read_file(self, path, mode='r'):
I don't read_file and write_file should be on the Port object. They don't have
anything to do with WebKit ports.
In general, we shouldn't try to make Port the all-sing, all-dance wrapper for
the world.
More information about the webkit-reviews
mailing list