[webkit-reviews] review granted: [Bug 37785] new-run-webkit-tests: add more --log options : [Attachment 53647] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Dirk Pranke <dpranke at chromium.org>'s
request for review:
Bug 37785: new-run-webkit-tests: add more --log options
https://bugs.webkit.org/show_bug.cgi?id=37785

Attachment 53647: Patch
https://bugs.webkit.org/attachment.cgi?id=53647&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Seems strange that some of these are constants and some are not:
 LOG_VALUES = ",".join(("actual", "config", LOG_DETAILED_PROGRESS, "expected",
 100			   LOG_NOTHING, LOG_PROGRESS, LOG_SUMMARY, "timing",
 101			   LOG_UNEXPECTED, LOG_UNEXPECTED_RESULTS))

Seems OK.  I don't know much about python's built in logging.  I wonder if
we're re-inventing any of that here.