[webkit-reviews] review granted: [Bug 37786] new-run-webkit-tests: checking the build should be optional : [Attachment 53648] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Apr 18 22:25:18 PDT 2010


Eric Seidel <eric at webkit.org> has granted Dirk Pranke <dpranke at chromium.org>'s
request for review:
Bug 37786: new-run-webkit-tests: checking the build should be optional
https://bugs.webkit.org/show_bug.cgi?id=37786

Attachment 53648: Patch
https://bugs.webkit.org/attachment.cgi?id=53648&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Two notes:
1.  Sad that we need this.  Seems like a hack around build system lameness.
2.  I hate that optparse doesn't have built in support for --no-.  We need to
make our own make_option wrapper which does automatic --no- generation as well
as puts the default value in the help text.


More information about the webkit-reviews mailing list