[webkit-reviews] review denied: [Bug 37743] Remove dependency of jsCurrentTime() on currentTime() : [Attachment 53588] a start

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Apr 17 14:05:39 PDT 2010


Gavin Barraclough <barraclough at apple.com> has denied Yong Li
<yong.li.webkit at gmail.com>'s request for review:
Bug 37743: Remove dependency of jsCurrentTime() on currentTime()
https://bugs.webkit.org/show_bug.cgi?id=37743

Attachment 53588: a start
https://bugs.webkit.org/attachment.cgi?id=53588&action=review

------- Additional Comments from Gavin Barraclough <barraclough at apple.com>
This looks like a good fix, but I'm a little concerned about the existing
function continuing to be called 'currentTime', since it does not return the
current time!  'tickCount()', perhaps, or 'monotonicTime()'?  I'd suggest
having caught this bug it'd be really good to change the name of that function
(plus 'currentTimeMS' to match), to make its meaning a little clearer & prevent
similar problems in the future.

r- to this patch for chromium breakage.


More information about the webkit-reviews mailing list