[webkit-reviews] review denied: [Bug 37664] Chromium: Add --chromium option to new-run-webkit-websocketserver : [Attachment 53456] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sat Apr 17 13:51:02 PDT 2010
Adam Barth <abarth at webkit.org> has denied review:
Bug 37664: Chromium: Add --chromium option to new-run-webkit-websocketserver
https://bugs.webkit.org/show_bug.cgi?id=37664
Attachment 53456: Patch
https://bugs.webkit.org/attachment.cgi?id=53456&action=review
------- Additional Comments from Adam Barth <abarth at webkit.org>
Oops. Misclick. This code is improperly factored. websocket_server.py should
have no knowledge of chromium or path_from_chromium_base. All that knowledge
needs to be moved into files with the word "chromium" in their names.
More information about the webkit-reviews
mailing list