[webkit-reviews] review denied: [Bug 36853] REGRESSION(r56552): Broken scrollbars size : [Attachment 52991] patch v1

[bugzilla-daemon at webkit.org]

Kenneth Rohde Christiansen <kenneth at webkit.org> has denied Antonio Gomes
(tonikitoo) <tonikitoo at webkit.org>'s request for review:
Bug 36853: REGRESSION(r56552): Broken scrollbars size
https://bugs.webkit.org/show_bug.cgi?id=36853

Attachment 52991: patch v1
https://bugs.webkit.org/attachment.cgi?id=52991&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>

> +    int scollbarThickness =
> +#if defined(Q_WS_MAC) && !defined(QT_MAC_USE_COCOA)
> +	   ScrollbarTheme::nativeTheme()->scrollbarThickness();
> +#else
> +	   0;
> +#endif

I think you should include the 'int scollbarThickness =' inside the ifdef's

The issue that bug 21300 (the regression origin) was working around was a Mac
Carbon
 9	   fix for the "Grow Box" at the bottom right side of the application
window: it was using
 10	    a rect sizing scrollbar thickness as the dimensions of this "Grow
Box" area.

I would say:

The regression was caused by r56552, which introduced a fix to bug
webkit.org/b/21300. 
The bug solved an issue with the resize handle on mac, but did it in a way that

affected all Qt platforms and thus broke the behavior on non-mac platforms.

This patch makes the mac specific change ifdef'ed and only applied for the mac
platform.