[webkit-reviews] review granted: [Bug 37311] Crash exiting fullscreen with captions enabled : [Attachment 52992] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Jer Noble <jer.noble at apple.com>'s
request for review:
Bug 37311: Crash exiting fullscreen with captions enabled
https://bugs.webkit.org/show_bug.cgi?id=37311

Attachment 52992: Patch
https://bugs.webkit.org/attachment.cgi?id=52992&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> -SOFT_LINK_CLASS(QTKit, QTMovieView)
> +SOFT_LINK_CLASS(QTKit, QTMovieLayer)

Does this need to go inside the ifdef?

> +#ifdef BUILDING_ON_TIGER
> +    // WebVideoFullscreenController is not supported on Tiger:
> +    ASSERT_NOT_REACHED();

I think it would be even better to put the entire body of the function inside
the #ifdef.