[webkit-reviews] review denied: [Bug 37152] [Qt] Rendering artifacts on Qt plugins when scrolling the page : [Attachment 52685] Always repaint QtPluginWidgets on geometry change

[bugzilla-daemon at webkit.org]

Simon Hausmann <hausmann at webkit.org> has denied Andreas Kling
<andreas.kling at nokia.com>'s request for review:
Bug 37152: [Qt] Rendering artifacts on Qt plugins when scrolling the page
https://bugs.webkit.org/show_bug.cgi?id=37152

Attachment 52685: Always repaint QtPluginWidgets on geometry change
https://bugs.webkit.org/attachment.cgi?id=52685&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
> diff --git a/WebKit/qt/ChangeLog b/WebKit/qt/ChangeLog
> index 5d014d2..09a4573 100644
> --- a/WebKit/qt/ChangeLog
> +++ b/WebKit/qt/ChangeLog
> @@ -1,3 +1,12 @@
> +2010-04-06  Andreas Kling  <andreas.kling at nokia.com>
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   Always repaint QtPluginWidgets when their geometry changes.
> +	   https://bugs.webkit.org/show_bug.cgi?id=37152
> +
> +	   * WebCoreSupport/FrameLoaderClientQt.cpp:

Patch looks good to me, but please include the bug title in the ChangeLog, so
that
it's clear from the ChangeLog what higher level issue is fixed.

The usual format is

    [Qt] Baz isn't repainted correctly after Foo
    https://bugs.webkit.org/...

    Because Foo is too small we also need to repaint
    Baz.

    ....