[webkit-reviews] review denied: [Bug 34730] [Qt] Null QObjects properties cause Segmentation Fault : [Attachment 52877] Rebased and changed coding style.

[bugzilla-daemon at webkit.org]

Simon Hausmann <hausmann at webkit.org> has denied Bruno Schmidt
<bruno.schmidt at gmail.com>'s request for review:
Bug 34730: [Qt] Null QObjects properties cause Segmentation Fault
https://bugs.webkit.org/show_bug.cgi?id=34730

Attachment 52877: Rebased and changed coding style.
https://bugs.webkit.org/attachment.cgi?id=52877&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>

> +	   No new tests. (OOPS!)

Please remove this line from the ChangeLog. After all you do have unit tests :)


>      // ECMA 9.2
> -    return jsBoolean(true);
> +    return jsBoolean(getObject() ? true : false);

Is the ? true : false part really needed? :)

>	       m_readOnlyValue(987),
> +	   m_objectStar(0),
>	       m_qtFunctionInvoked(-1) { }

The indentation seems off here.

The rest of the patch looks good to me. Good catch, thank you!

r- because of the ChangeLog and indentation.