[webkit-reviews] review denied: [Bug 37320] [Qt] tst_QWebFrame::popupFocus() fails : [Attachment 52980] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 9 13:19:28 PDT 2010


Kenneth Rohde Christiansen <kenneth at webkit.org> has denied yi shen
<yi.4.shen at nokia.com>'s request for review:
Bug 37320: [Qt] tst_QWebFrame::popupFocus() fails
https://bugs.webkit.org/show_bug.cgi?id=37320

Attachment 52980: patch
https://bugs.webkit.org/attachment.cgi?id=52980&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>

> +
> +	   The QWebPopup class has been moved & renamed, so
tst_QWebFrame::popupFocus() should use the class name "QComboBox", rather than
"WebCore::QWebPopup" to find the popup menu. 
> +

:-( Please keep the changelog at max 80-100 char per line as everyone else.
sorry


More information about the webkit-reviews mailing list