[webkit-reviews] review granted: [Bug 37349] [RenderStyle Cleanup] Clean up BorderValue, CollapsedBorderValue, BorderData and OutlineValue : [Attachment 52981] Patch

[bugzilla-daemon at webkit.org]

Adam Roben (aroben) <aroben at apple.com> has granted Dave Hyatt
<hyatt at apple.com>'s request for review:
Bug 37349: [RenderStyle Cleanup] Clean up BorderValue, CollapsedBorderValue,
BorderData and OutlineValue
https://bugs.webkit.org/show_bug.cgi?id=37349

Attachment 52981: Patch
https://bugs.webkit.org/attachment.cgi?id=52981&action=review

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
>  class BorderData {
> +friend class RenderStyle;

I think we normally put friend declarations at the start of "private:"
sections. But maybe that's not as common as I think? (Same goes for BorderValue
and CollapsedBorderValue.)

> +    Color color() const { return m_borderColor; }

Could make this return a const Color& while you're at it.

r=me